[EuiDataGrid] Remove pointer-events: none on header actions#9177
Merged
mgadewoll merged 2 commits intoelastic:mainfrom Nov 5, 2025
Merged
[EuiDataGrid] Remove pointer-events: none on header actions#9177mgadewoll merged 2 commits intoelastic:mainfrom
pointer-events: none on header actions#9177mgadewoll merged 2 commits intoelastic:mainfrom
Conversation
- prevent potential test issues when the button is not clickable while the button is transitioning
- transition changed, we need to give it more time to ensure the button is available
Collaborator
💚 Build Succeededcc @mgadewoll |
Collaborator
💚 Build Succeeded
cc @mgadewoll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up to #9166
It removes the previously added
pointer-events: none, as this can interfere with tests that try to click the button element during transition.Note
The tests on the original PR succeeded but tests on main after merge failed. 🤷♀️
Additionally the test increases and unifies the wait time before clicking the action button in
draggable_columns.spec.tsxto ensure the button has had enough time to transition.Why are we making this change?
🩹 Test robustness: Prevent flaky tests.
Screenshots #
Impact to users
🟢 Test related change only.
QA
General checklist
@defaultif default values are missing) and playground toggles